-
Notifications
You must be signed in to change notification settings - Fork 8
CLOUDP-314901 OIDC CRD changes + validation #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
713d6d2
to
7c23143
Compare
SimonBaeumer
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small comment to the URL parse func.
lucian-tosa
approved these changes
May 2, 2025
anandsyncs
approved these changes
May 18, 2025
vinilage
approved these changes
May 20, 2025
anandsyncs
reviewed
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding new
OIDCProviderConfig
struct toAuthentication
struct and new AuthModeOIDC
.Security.Authentication
struct is reused also in AppDBSpec it will be available there as well. It will be as usual overridden inmongodb-kubernetes/api/v1/om/opsmanager_types.go
Line 622 in f0050b8
I believe it is worth noting this behaviour, but not change it as part of this project.
Proof of Work
New Unit test that verify validation and another set of webhook tests are under way.
Next steps
Checklist
Reminder (Please remove this when merging)